Remove XStream from Image Atlas Generation #6505
Draft
+420
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rjhancock
commented
Feb 6, 2025
rjhancock
commented
- Removes the libraries from the CreateImageAtlas utility that relate to XStream.
- Adds 2 utility classes for storing data about the image atlases.
- Adjusts classes to ensure fewest code changes needed (converting from new classes to Map<String, String> and back as needed).
- Removes some additional Gradle warnings.
Updated Libraries
Fix Gradle Warnings
IllianiCBT
reviewed
Feb 6, 2025
| @@ -0,0 +1,85 @@ | |||
| /* | |||
| * Copyright (c) 2024 - The MegaMek Team. All Rights Reserved. | |||
There was a problem hiding this comment.
Should this be 2025 now?
There was a problem hiding this comment.
Yes it should. It's also 1130 at night and I've been up since 6a.
There was a problem hiding this comment.
No criticism intended. Just spotted it while I was failing to sleep :D
There was a problem hiding this comment.
lol I took none. I get you on it several times, I expect the same in return when I miss something.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6505 +/- ##
============================================
- Coverage 29.05% 29.03% -0.03%
+ Complexity 15156 15150 -6
============================================
Files 2835 2838 +3
Lines 279142 279324 +182
Branches 49214 49238 +24
============================================
- Hits 81100 81092 -8
- Misses 192665 192855 +190
Partials 5377 5377 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.