Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for IS Unofficial save changing tech base and level to Clan Level 2 #6386

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jan 10, 2025

Fix for MML saving IS Unofficial units (other than Meks) as Clan Standard.

T_IS_UNOFFICIAL needs to fall through to the default block wherever it is.

Testing:

  • Ran all 3 projects' unit tests.
  • Saved units with IS Unofficial tech level and confirmed loading.
  • Added unit test for MML

Close MegaMek/megameklab#1686

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.59%. Comparing base (e85cf17) to head (d6c9fff).
Report is 27 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6386      +/-   ##
============================================
- Coverage     28.59%   28.59%   -0.01%     
+ Complexity    14088    14087       -1     
============================================
  Files          2784     2784              
  Lines        273079   273079              
  Branches      48380    48380              
============================================
- Hits          78100    78098       -2     
- Misses       190999   191000       +1     
- Partials       3980     3981       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock rjhancock merged commit f14dc64 into MegaMek:master Jan 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.03-SNAPSHOT] Tech Level and Tech Base not saving on Combat Vehicles with pre-2820 design years
3 participants