fix: fixes a class cast bug and an error in the argument parsing algorithm #6375
+37
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6375 +/- ##
============================================
+ Coverage 28.65% 28.98% +0.32%
- Complexity 14088 14089 +1
============================================
Files 2760 2674 -86
Lines 272561 269483 -3078
Branches 48333 47962 -371
============================================
+ Hits 78099 78101 +2
+ Misses 190482 187403 -3079
+ Partials 3980 3979 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6374
The changes I made to the nuke command originally made it impossible to use the custom nuke command, this change allows the argument parser to discover which is the correct set of arguments to use in case you are writting only positional arguments.
This also fixes an exception that was happening due to a bad cast.