Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acar/on megamek #6353

Closed
wants to merge 12 commits into from
Closed

Acar/on megamek #6353

wants to merge 12 commits into from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Jan 4, 2025

Abstract Combat Auto Resolution

Implements ACAR in MegaMek, for quick and easy simulations.

Screenshot of the complete implementation

Screenshot 2025-01-06 at 01 29 07

Setup Panel

The Auto Resolve setup panel allows you to set how many games you want running in parallel, how many simulations you want to run prior to the auto-resolve to generate the chances dialog, a check that enables or disables the pre-simulations and chance dialog, and the "run simulations" button.

Screenshot 2025-01-06 at 01 29 23

New splash screen, hand made by localy sources trans humans, specifically it was made by me (because I like to draw and paint, so I figured why not do it myself?)

Screenshot 2025-01-06 at 01 30 23

Report detail

Glamour shoots of the reports generated by ACAR.

Screenshot 2025-01-06 at 01 29 44 Screenshot 2025-01-06 at 01 30 08

Uses AS and ACS and SBF mix

The rules it uses to run the simulations is a mixture of Alpha Strike, SBF and ACS. The feature is very much under development and this current iteration of it is both a proof of concept and an MVP, I know it is not in the state everyone would want it to be, but it works, it is reasonable, and its under constant work and improvements being done.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.66%. Comparing base (2451519) to head (6afa386).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6353      +/-   ##
============================================
- Coverage     28.98%   28.66%   -0.32%     
+ Complexity    14089    14088       -1     
============================================
  Files          2674     2755      +81     
  Lines        269472   272430    +2958     
  Branches      47964    48306     +342     
============================================
  Hits          78101    78101              
- Misses       187390   190348    +2958     
  Partials       3981     3981              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return (boardLocation != null) && hasBoard(boardLocation.boardId());
}

public boolean hasBoard(int boardId) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'boardId' is never used.
@Scoppio Scoppio marked this pull request as ready for review January 6, 2025 04:28
@Scoppio Scoppio self-assigned this Jan 6, 2025
@Scoppio Scoppio closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant