-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acar/on megamek #6353
Acar/on megamek #6353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6353 +/- ##
============================================
- Coverage 28.98% 28.66% -0.32%
+ Complexity 14089 14088 -1
============================================
Files 2674 2755 +81
Lines 269472 272430 +2958
Branches 47964 48306 +342
============================================
Hits 78101 78101
- Misses 187390 190348 +2958
Partials 3981 3981 ☔ View full report in Codecov by Sentry. |
return (boardLocation != null) && hasBoard(boardLocation.boardId()); | ||
} | ||
|
||
public boolean hasBoard(int boardId) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
megamek/src/megamek/common/autoresolve/acar/action/EngagementControlToHitData.java
Show resolved
Hide resolved
megamek/src/megamek/common/autoresolve/acar/manager/InitiativeHelper.java
Show resolved
Hide resolved
megamek/src/megamek/common/autoresolve/acar/manager/InitiativeHelper.java
Show resolved
Hide resolved
megamek/src/megamek/common/autoresolve/acar/report/EndPhaseReporter.java
Show resolved
Hide resolved
megamek/src/megamek/common/autoresolve/converter/BalancedConsolidateForces.java
Fixed
Show fixed
Hide fixed
4ffb3c4
to
0adee25
Compare
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/internationalization/Internationalization.java
Fixed
Show fixed
Hide fixed
megamek/src/megamek/common/autoresolve/converter/ForceConsolidation.java
Show resolved
Hide resolved
794f42e
to
e0d2273
Compare
00d5cbe
to
8bdc385
Compare
Abstract Combat Auto Resolution
Implements ACAR in MegaMek, for quick and easy simulations.
Screenshot of the complete implementation
Setup Panel
The Auto Resolve setup panel allows you to set how many games you want running in parallel, how many simulations you want to run prior to the auto-resolve to generate the chances dialog, a check that enables or disables the pre-simulations and chance dialog, and the "run simulations" button.
New splash screen, hand made by localy sources trans humans, specifically it was made by me (because I like to draw and paint, so I figured why not do it myself?)
Report detail
Glamour shoots of the reports generated by ACAR.
Uses AS and ACS and SBF mix
The rules it uses to run the simulations is a mixture of Alpha Strike, SBF and ACS. The feature is very much under development and this current iteration of it is both a proof of concept and an MVP, I know it is not in the state everyone would want it to be, but it works, it is reasonable, and its under constant work and improvements being done.