Feature command queue after morph commands #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanvo
force-pushed
the
feat/command-priority
branch
from
b116e4e to
86da16e
Compare
This was resulting in non-intuitive and surprising behaviour when queuing commands. Removing this system results in Megaglest behaving more like other RTS games. For instance, the following are now possible and weren't previously: - Queuing multiple attack ground commands to move along a specific path attacking all enemies on the way. - Queuing attack ground followed by hold position, which is a sensible thing to do if you want a unit to guard a specific area. - Queuing a move command followed by a produce command, if you want to have your summoner summon a daemon at a specific location. The behaviour of queuing the stop command is unchanged, and commands that must be the last in the queue, such as morphing, are still properly replaced when something else is queued.
if(unitType != NULL && ct->getClass() == ccBuild)
for unit->computeCommandType
pavanvo
force-pushed
the
feat/command-priority
branch
from
52c3628 to
8bc5abb
Compare
pavanvo
changed the title
added 6 commits
September 6, 2022 17:43
to NetworkCommand class to prevent collision morph with build
pavanvo
force-pushed
the
feat/command-priority
branch
from
80681f6 to
d5ac512
Compare
|
I think we need to, update abilities UI on position invalid and another cast blocking staff like stuns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR kinda improved command priority system, more intuitive, without any restrictions