Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup needed #8

Open
3 of 5 tasks
davb opened this issue Apr 21, 2018 · 1 comment
Open
3 of 5 tasks

Cleanup needed #8

davb opened this issue Apr 21, 2018 · 1 comment

Comments

@davb
Copy link
Contributor

davb commented Apr 21, 2018

Before we work further on this tool, I would like to do the following:

  • use async/await instead of ugly Promises. In most of the code promises are not chained properly. Require Node 8+ in package.json to enable this.
  • add code linting with eslint
  • fix indentation: some files use tabs, other spaces. All should be set to two spaces
  • rename the middleware folder to services. Middlewares are functions that take (req, res, next) and respond to requests. Functions that deal with data should be called services or model.
  • move all constants to constants.js, especially environment variables; throw errors when required constants are blank
@davb
Copy link
Contributor Author

davb commented Apr 21, 2018

@tjeanneau @lourou what do you think?

@lourou lourou mentioned this issue Apr 22, 2018
lourou added a commit that referenced this issue Apr 22, 2018
@lourou lourou mentioned this issue Apr 22, 2018
lourou added a commit that referenced this issue Apr 22, 2018
lourou added a commit that referenced this issue Apr 22, 2018
@lourou lourou removed their assignment Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants