Skip to content

Commit

Permalink
Cygwin: pipe: Avoid false EOF while reading output of C# programs.
Browse files Browse the repository at this point in the history
- If output of C# program is redirected to pipe, pipe reader falsely
  detects EOF. This happens after overhaul of pipe implementation.
  This patch fixes the issue.

Addresses:
  https://cygwin.com/pipermail/cygwin/2021-November/249777.html
  • Loading branch information
tyan0 authored and github-cygwin committed Nov 8, 2021
1 parent 0390cc8 commit 1f7aa67
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion winsup/cygwin/fhandler_pipe.cc
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ fhandler_pipe::raw_read (void *ptr, size_t& len)
}
}

if (nbytes_now == 0 || status == STATUS_BUFFER_OVERFLOW)
if ((nbytes_now == 0 && !NT_SUCCESS (status))
|| status == STATUS_BUFFER_OVERFLOW)
break;
}
ReleaseMutex (read_mtx);
Expand Down
4 changes: 4 additions & 0 deletions winsup/cygwin/release/3.3.2
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ Bug Fixes
Addresses: https://sourceware.org/pipermail/newlib/2021/018626.html

- Fix a permission problem when writing ACLs on Samba.

- Fix the issue that pipe reader falsely detects EOF if the output of
the C# program is redirected to the pipe.
Addresses: https://cygwin.com/pipermail/cygwin/2021-November/249777.html

0 comments on commit 1f7aa67

Please sign in to comment.