Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7528 Added Saved Codes UI builder for Qi Core and handled special… #430

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

RohitKandimalla
Copy link
Contributor

… case for SNOMED Versions

MADiE PR

Jira Ticket: MAT-7528
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@RohitKandimalla RohitKandimalla self-assigned this Jan 7, 2025
@RohitKandimalla RohitKandimalla requested a review from a team as a code owner January 7, 2025 18:49
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (3bc9579) to head (967d60b).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ion/codesSubSection/codeSubSection/CodeSection.tsx 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #430      +/-   ##
===========================================
+ Coverage    90.30%   90.41%   +0.11%     
===========================================
  Files           74       74              
  Lines         1980     1993      +13     
  Branches       368      375       +7     
===========================================
+ Hits          1788     1802      +14     
+ Misses         118      117       -1     
  Partials        74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nmorasb nmorasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please raise one or more tech debt stories to cover refactoring editor code to better separate model-specific components and logic

@RohitKandimalla RohitKandimalla merged commit a00a7eb into develop Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants