Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7829: 1st selection of Model triggers validation when selection is valid #167

Merged

Conversation

etan-sb
Copy link
Contributor

@etan-sb etan-sb commented Nov 7, 2024

If a user selects a Model from the dropdown, do not show 'A CQL library model is required.' validation message. Only show validation message if the user clicks into dropdown, then clicks out of dropdown without select a dropdown value

MADiE PR

Jira Ticket: MAT-7829
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

…ry model is required.' validation message. Only show validation message if the user clicks into dropdown, then clicks out of dropdown without select a dropdown value
@etan-sb etan-sb requested a review from a team as a code owner November 7, 2024 00:17
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (bb1c1f0) to head (7f2c6f0).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #167      +/-   ##
===========================================
- Coverage    84.95%   84.92%   -0.03%     
===========================================
  Files           21       21              
  Lines          545      544       -1     
  Branches       112      112              
===========================================
- Hits           463      462       -1     
  Misses          65       65              
  Partials        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@etan-sb etan-sb merged commit bae74ec into develop Nov 11, 2024
12 checks passed
@etan-sb etan-sb deleted the feature/MAT-7829/fix-validation-on-model-field-selection branch November 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants