Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Measure two-step delete, with sliding buttons #75

Closed
wants to merge 6 commits into from

Conversation

jtferns
Copy link
Contributor

@jtferns jtferns commented Jan 26, 2014

Story

Notes

  • Replaced measure's delete button with consistent two-step delete button used within patient results and patient data criteria, moved measure settings gear icon into title bar
  • Updated styling to match v5 mockups
  • Added simple CSS3 sliding animation for buttons

Images

0105closed
0105settings
0105expanded
0387closed
0387settings
0387expanded

.fa {
color: @brand-primary;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance the arbitrary padding sizes and the explicit browser support for transitions (rather than using a mixin) could be cleaned up... can you work with Liam to get this CSS cleaned up, he'll likely have good approaches.

@pkmitre
Copy link
Contributor

pkmitre commented Jan 29, 2014

Noted one issue: if you click the gear, and then click the minus, clicking the gear doesn't hide the resulting buttons; it should hide the buttons and reset them.

}
}
.measure-settings-expanded {
width: 16%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting a percentage-based width makes me pretty nervous... this might be worth talking through in person. PS, http://demosthenes.info/blog/775/Which-CSS-Measurements-To-Use-When is a good resource (even if Bootstrap breaks some of these standards when it comes to ems vs pixels).

@jtferns
Copy link
Contributor Author

jtferns commented Feb 6, 2014

Updated to use better styles and template, closing and will re-open with rebased branch

@jtferns jtferns closed this Feb 6, 2014
@jtferns jtferns deleted the measure_delete branch February 6, 2014 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants