Replace Gridster with Gridstack and clean up styling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreyd
suggested changes
Oct 21, 2016
| widget.find('.widget-hotness').removeClass('hotness2'); | ||
| widget.find('.widget-hotness').removeClass('hotness3'); | ||
| widget.find('.widget-hotness').removeClass('hotness4'); | ||
| widget.find('.widget-temperature').removeClass('temperature0'); |
There was a problem hiding this comment.
removeClass can take many arguments, so this could be
widget.find('.widget-temperature').removeClass("temperature0", "temperature1", ...);| var min = widget.find('.widget-hotness')[0].getAttribute('data-min'); | ||
| var max = widget.find('.widget-hotness')[0].getAttribute('data-max'); | ||
| var min = widget.find('.widget-temperature')[0].getAttribute('data-min'); | ||
| var max = widget.find('.widget-temperature')[0].getAttribute('data-max'); |
There was a problem hiding this comment.
Probably best to store widget.find('.widget-temperature') into a variable, as you use it many times (and dom lookups are quite expensive).
| @@ -0,0 +1,1738 @@ | |||
| /** | |||
There was a problem hiding this comment.
Is this library (and the other 3rd party stuff) avaliable as gems/npm that you can reference, rather than include?
This will make staying up to date much easier.
| @@ -0,0 +1,304 @@ | |||
| /*! | |||
There was a problem hiding this comment.
Yeah, pretty sure this is available as a gem
geoffreyd
suggested changes
Oct 21, 2016
app/assets/javascripts/kiteboard.js
Outdated
|
|
||
| resizeWidgets: function () { | ||
| if (window.innerWidth < $('.grid-stack').width()) { | ||
| var grid = $('.grid-stack').data('gridstack'); |
There was a problem hiding this comment.
multiple $('.grid-stack')s ... and other duplicates
Mbuckley0
force-pushed
the
change-from-gridster-to-gridstack
branch
from
f90fb6e to
1d8eda3
Compare
geoffreyd
approved these changes
Oct 21, 2016
Mbuckley0
force-pushed
the
change-from-gridster-to-gridstack
branch
from
1d8eda3 to
9a40a16
Compare
Mbuckley0
force-pushed
the
change-from-gridster-to-gridstack
branch
from
3e15d5b to
2289831
Compare
Mbuckley0
force-pushed
the
change-from-gridster-to-gridstack
branch
2 times, most recently
from
5562510 to
7fcc89a
Compare
Mbuckley0
force-pushed
the
change-from-gridster-to-gridstack
branch
from
7fcc89a to
44ed8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.