Update the hashes domain to use PSA macros in depends.py
#9634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-mezei-arm
added
enhancement
needs-ci
gabor-mezei-arm
force-pushed
the
9144_update_depends.py_hashes_domain
branch
from
8ab32ac to
fcfc93d
Compare
5 tasks
5 tasks
Signed-off-by: Gabor Mezei <[email protected]>
With mutual exclusion multiple symbols can be handled as one thus if one of them need to be turned of them all of them will be. Also update the Job class for the symbols in the mutual exclusion jobs to be referenced separately. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
gabor-mezei-arm
force-pushed
the
9144_update_depends.py_hashes_domain
branch
from
fcfc93d to
baa11a9
Compare
gabor-mezei-arm
removed
the
needs-preceding-pr
gabor-mezei-arm
added
needs-review
ronald-cron-arm
removed
the
needs-reviewer
minosgalanakis
previously approved these changes
Jan 17, 2025
tests/scripts/depends.py
Outdated
| alter_names = {'!' + symbol for symbol in config_settings.keys()} | ||
| job = Job(description, config_settings, commands, alter_names) | ||
| self.jobs.append(job) | ||
| valid_symbols -= config_settings.keys() |
There was a problem hiding this comment.
Question.
Updating the valid_symbols while iterating through the mutual_exlusion implies that that a single valid_symbol can only pair with a single group. So we cannot have two groups that depend on the same valid_symbol
Is that intended as per design?
tests/scripts/depends.py
Outdated
| @@ -630,8 +630,11 @@ def __init__(self, options, conf): | |||
| # across various modules, but it depends on either SHA256 or SHA512. | |||
| # As a consequence an "exclusive" test of anything other than SHA256 | |||
| # or SHA512 with MBEDTLS_ENTROPY_C enabled is not possible. | |||
| # Note for update: when MBEDTLS_SHA3_C is removed the mutual_exclusion | |||
There was a problem hiding this comment.
We need a common operator to indicate things that need to be done in the documentation. Until that is decided shoud we use TODO: which is global?
Signed-off-by: Gabor Mezei <[email protected]>
Now it is supported to the select a symbol for multiple mutual exclusion groups. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
depends.pyuse PSA macros for thehashesdomain.Resolve #9144
Depends on #9292
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.