Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix test_suite_platform failure with Asan on modern Clang #8558

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Backport 2.28: Fix test_suite_platform failure with Asan on modern Clang #8558

merged 1 commit into from
Nov 23, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

Backport of #8286. The problematic test case doesn't exist in 2.28, but backport the new helper macros.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@gilles-peskine-arm
Detect enabled GCC/Clang sanitizers
c3a9bdb 
Occasionally we want tests to take advantage of sanitizers, or work around
them.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most) labels Nov 22, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Nov 22, 2023
Merged
3 tasks
minosgalanakis
minosgalanakis approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Nov 23, 2023
@daverodgman daverodgman added this pull request to the merge queue Nov 23, 2023
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 60dcdd1 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daverodgman daverodgman daverodgman approved these changes

@minosgalanakis minosgalanakis minosgalanakis approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @daverodgman @minosgalanakis