Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for #7649 : add command for server9-bad-saltlen #8480

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Backports for #7649 : add command for server9-bad-saltlen #8480

merged 7 commits into from
Nov 8, 2023

Conversation

yuhaoth
Copy link
Contributor

@yuhaoth yuhaoth commented Nov 6, 2023 •
edited by minosgalanakis
Loading

Description

This is backports of #7649.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@yuhaoth yuhaoth mentioned this pull request Nov 6, 2023
Merged
3 tasks
@yuhaoth yuhaoth added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-m Estimated task size: medium (~1w) component-test Test framework and CI scripts labels Nov 6, 2023
gilles-peskine-arm
gilles-peskine-arm approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer labels Nov 8, 2023
@gilles-peskine-arm
Copy link
Contributor

This is a trivial backport with low risk and forked recently, so I am going to merge it without going through the merge queue.

@gilles-peskine-arm gilles-peskine-arm merged commit bfc1844 into Mbed-TLS:mbedtls-2.28 Nov 8, 2023
@gilles-peskine-arm
Copy link
Contributor

This is a trivial backport with low risk and forked recently, so I am going to merge it without going through the merge queue.

Well, I shouldn't have. There's a new file which was created before the license update, so it needs the license to be updated.

@yuhaoth yuhaoth deleted the backports/7649/add-command-for-server9-bad-saltlen branch December 6, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review single-reviewer This PR qualifies for having only one reviewer size-m Estimated task size: medium (~1w)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhaoth @gilles-peskine-arm