Backport 2.28: Support cpuid for win32 #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__cpuid` has two kinds of signatures in different headers depending on the target OS. We make it consistent between the usages ang the included header. Signed-off-by: Pengyu Lv <[email protected]>
Change the type of array that stores the cpuinfo data to int[4] to match the signature of `__cpuinfo` in `intrin.h` header file. Signed-off-by: Pengyu Lv <[email protected]>
MinGW provides both kinds of implementations of `__cpuid`, but since `cpuid.h` is provided by GNUC, so we should choose the implementation by the compiler type instead of OS type. Signed-off-by: Pengyu Lv <[email protected]>
Signed-off-by: Pengyu Lv <[email protected]>
Signed-off-by: Pengyu Lv <[email protected]>
lpy4105
added
bug
needs-review
|
Is there nothing to be done for |
Signed-off-by: Pengyu Lv <[email protected]>
Since |
Signed-off-by: Pengyu Lv <[email protected]>
lpy4105
force-pushed
the
backport-2.28/issue/support-cpuid-for-win32
branch
from
1446cd9 to
e6cbec8
Compare
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #8339
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")