Fixes log level for got supported group message #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcagriaksoy
force-pushed
the
branch_old_try
branch
from
4ed27a2 to
d9f2280
Compare
3 tasks
gilles-peskine-arm
added
bug
needs-review
gilles-peskine-arm
requested changes
Sep 14, 2023
gilles-peskine-arm
added
needs-work
and removed
needs-review
Signed-off-by: mcagriaksoy <[email protected]>
|
Please don't include merge commits in pull requests unless necessary to resolve a merge conflict with a complicated history, or a CI failure. They are time-consuming to review. |
mcagriaksoy
force-pushed
the
branch_old_try
branch
3 times, most recently
from
998ad9c to
cd7e82d
Compare
mcagriaksoy
force-pushed
the
branch_old_try
branch
2 times, most recently
from
0329593 to
7f84471
Compare
gilles-peskine-arm
added
approved
ChangeLog.d/fix-log-level-msg.txt
Outdated
| @@ -0,0 +1,2 @@ | |||
| Bugfix | |||
| * Fix log level for the got supported group message. Fixes #6765 | |||
There was a problem hiding this comment.
The comment in the PR is much more useful than this, so could you change this to something like the following (also note the final period/full stop).
* Fix an incorrect log level that was causing excessive messages during
DTLS handshakes. Fixes #6765.
bf351dd
mcagriaksoy
force-pushed
the
branch_old_try
branch
from
7f84471 to
bf351dd
Compare
Signed-off-by: mcagriaksoy <[email protected]>
mcagriaksoy
force-pushed
the
branch_old_try
branch
from
bf351dd to
920ee02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the copy PR of the previous #7314
somehow I cannot re-open that.
This PR resolve #6765 issue. During one successful DTLS handshake, user seeing many message caused by wrong log level.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.