Backport 2.28: Fix boolean options in the wrong section #8173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean options that modify the behavior of a module are supposed to be in the "feature support" section, not in the "configuration options" support: that section is documented to contain commented-out definitions with a value, for which the comment contains the default version. In particular, merely uncommenting a definition in the "configuration options" section is not supposed to change anything. Move the offending boolean options to the proper section. This causes those options to be enabled by `config.py full` unless explicitly excluded. For the moved options: * Everest is already explicitly excluded. * The ALT options need to link against a custom function, so exclude them. * `MBEDTLS_TLS_DEFAULT_ALLOW_SHA1_IN_KEY_EXCHANGE` is ok for testing, and is currently never tested in `all.sh`. With this commit, we will now test the library with it enabled in configurations based on `full`. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
needs-ci
3 tasks
Signed-off-by: Gilles Peskine <[email protected]>
daverodgman
previously approved these changes
Sep 8, 2023
|
LGTM except for pylint error |
daverodgman
added
the
single-reviewer
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
the
needs-review
daverodgman
approved these changes
Sep 8, 2023
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
config.h, boolean options shouldn't go in the “Module configuration options”: that's for defaults of options with a value. This is a partial backport of #8161: the other commits there are about things introduced in 3.x.PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")