Backport 2.28: check_test_cases.py: support to collect test cases for compat.sh #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 30, 2023 10:25
The option --list-test-case lists all potential test cases without executing them. The test case description is identical with $TITLE during test case execution. Signed-off-by: Yanray Wang <[email protected]>
Test case description in compat.sh is in format of
[ogm]->[ogm] TLSmode, VERIFY CIPHERSUITE_NAME
This program calls compat.sh to list all potential test case
descriptions then checks test case duplication.
Signed-off-by: Yanray Wang <[email protected]>
Test case description is printed by different block of code. This causes code maintenance harder since we need to maintain two parts of code with same functionality. print_test_title is used to control test case description in compat.sh Signed-off-by: Yanray Wang <[email protected]>
Signed-off-by: Yanray Wang <[email protected]>
uniform_title is used to print identical format of $TITLE between --list-test-case and run_client. In such way, no matter how $TITLE is developed, --list-test-case will in the same format of test case description as stored in OUTCOME.CSV. Signed-off-by: Yanray Wang <[email protected]>
Signed-off-by: Yanray Wang <[email protected]>
This commit includes: - use subprocess.check_output to report error and capture return value - add comment as a reminder for option --list-test-case Signed-off-by: Yanray Wang <[email protected]>
Signed-off-by: Yanray Wang <[email protected]>
Signed-off-by: Yanray Wang <[email protected]>
yanrayw
added
enhancement
size-s
3 tasks
When calling `add_xxx_ciphersuites`, we have to set MODE properly. This commit adjusts order to address this issue in list_test_case which matches what we do in a normal execution. Signed-off-by: Yanray Wang <[email protected]>
yanrayw
force-pushed
the
2.28-7094-collect-compatsh-test-cases
branch
from
3b3cd2e to
b2cd07c
Compare
yanrayw
added
needs-review
tgonzalezorlandoarm
requested changes
Aug 30, 2023
Signed-off-by: Yanray Wang <[email protected]>
tgonzalezorlandoarm
approved these changes
Aug 30, 2023
lpy4105
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7165
Comments
This PR adds support to list all potential test cases in
compat.shby./tests/compat.sh --list-test-case. Therefore,check_test_cases.pyis able to collect those test case description in order to report duplicated test cases.To analyze outcome by
analyze_outcomes.py, the test case description should be identical withOUTCOME.CSVin #7136 . Please consider those two PRs together.Gatekeeper checklist