Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Use mbedtls_ct_uint_if() rather than mbedtls_ct_cond_select_sign() #7545

Merged
merged 1 commit into from
May 4, 2023
Merged

Backport 2.28: Use mbedtls_ct_uint_if() rather than mbedtls_ct_cond_select_sign() #7545

merged 1 commit into from
May 4, 2023

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented May 3, 2023 •
edited by daverodgman
Loading

Description

Saves a few bytes by removing an effectively duplicated function

From @daverodgman - thanks!

Gatekeeper checklist

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request May 3, 2023
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added enhancement needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-optimisation size-xs Estimated task size: extra small (a few hours at most) labels May 3, 2023
yanrayw
yanrayw approved these changes May 4, 2023
View reviewed changes
Copy link

@yanrayw yanrayw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanrayw yanrayw added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels May 4, 2023
@daverodgman daverodgman removed the needs-ci Needs to pass CI tests label May 4, 2023
@daverodgman daverodgman merged commit 2e4541f into Mbed-TLS:mbedtls-2.28 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanrayw yanrayw yanrayw approved these changes

@daverodgman daverodgman daverodgman approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-high High priority - will be reviewed soon size-optimisation size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-cosgrove-arm @daverodgman @yanrayw