Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.28: Update gen_prvkey_mx paras to align with comments and c code #7470

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

xkqian
Copy link
Contributor

@xkqian xkqian commented Apr 21, 2023

Description

Backport from: #7450

The prototype of function mbedtls_ecp_gen_privkey_mx() doesn't allign with the implementation and the comments.
Update it to align with exist comments.

Gatekeeper checklist

@xkqian xkqian added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests component-docs Docs / website issues filed here for tracking priority-medium Medium priority - this can be reviewed as time permits labels Apr 21, 2023
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca merged commit b5b0649 into Mbed-TLS:mbedtls-2.28 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-docs Docs / website issues filed here for tracking needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, priority-medium Medium priority - this can be reviewed as time permits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants