Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify LTS lifetime #7383

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Clarify LTS lifetime #7383

merged 3 commits into from
Apr 17, 2023

Conversation

yanesca
Copy link
Contributor

@yanesca yanesca commented Mar 30, 2023 •
edited by minosgalanakis
Loading

Description

Users can get more value out of our LTS releases and plan transition between versions better if the documentation is more clear about the lifetime of LTS branches.

Gatekeeper checklist

@yanesca
Clarify LTS lifetime
e6c0fd0 
Signed-off-by: Janos Follath <[email protected]>
@yanesca yanesca added enhancement needs-review Every commit must be reviewed by at least two team members, component-docs Docs / website issues filed here for tracking needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Mar 30, 2023
@davidhorstmann-arm davidhorstmann-arm added the single-reviewer This PR qualifies for having only one reviewer label Mar 30, 2023
@davidhorstmann-arm davidhorstmann-arm self-requested a review March 30, 2023 15:00
davidhorstmann-arm
davidhorstmann-arm previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Mar 30, 2023
daverodgman
daverodgman requested changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@daverodgman daverodgman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a given that an LTS will be supported for 3 years; I've suggested some more precise wording.

BRANCHES.md Outdated Show resolved Hide resolved
@yanesca @daverodgman
Update BRANCHES.md
384e848 
Co-authored-by: Dave Rodgman <[email protected]>
Signed-off-by: Janos Follath <[email protected]>
@yanesca yanesca added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer labels Apr 3, 2023
daverodgman
daverodgman previously approved these changes Apr 4, 2023
View reviewed changes
@yanesca yanesca mentioned this pull request Apr 5, 2023
Merged
3 tasks
@yanesca yanesca added single-reviewer This PR qualifies for having only one reviewer and removed needs-ci Needs to pass CI tests labels Apr 5, 2023
@yanesca
Copy link
Contributor Author

yanesca commented Apr 5, 2023

Backport is up and ready for review: #7409

@yanesca yanesca added the approved Design and code approved - may be waiting for CI or backports label Apr 5, 2023
@yanesca yanesca added the needs-backports Backports are missing or are pending review and approval. label Apr 5, 2023
gilles-peskine-arm
gilles-peskine-arm requested changes Apr 11, 2023
View reviewed changes
BRANCHES.md Outdated Show resolved Hide resolved
@gilles-peskine-arm gilles-peskine-arm added needs-work and removed approved Design and code approved - may be waiting for CI or backports needs-review Every commit must be reviewed by at least two team members, labels Apr 11, 2023
@yanesca @gilles-peskine-arm
BRANCHES.md: improve wording
bd99835 
Co-authored-by: Gilles Peskine <[email protected]>
Signed-off-by: Janos Follath <[email protected]>
@yanesca yanesca added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Apr 11, 2023
davidhorstmann-arm
davidhorstmann-arm approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 11, 2023
gilles-peskine-arm
gilles-peskine-arm approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman daverodgman merged commit d455e90 into Mbed-TLS:development Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@daverodgman daverodgman daverodgman left review comments

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-docs Docs / website issues filed here for tracking enhancement needs-backports Backports are missing or are pending review and approval. priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanesca @daverodgman @gilles-peskine-arm @davidhorstmann-arm