Fix the problem of printing "Terminated" in compat.sh under Ubuntu-22.04 #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2023 11:54
Under Ubuntu-22.04, wait command prints out Terminated message if the process has been killed by kill command. This messes up the output in compat.sh Signed-off-by: Yanray Wang <[email protected]>
Under Ubuntu-22.04, wait command prints out Terminated message. Therefore server process is handled with identical ways like other processes in compat.sh. In addition, PROCESS_ID is renamed as SRV_PID to improve code readability. Signed-off-by: Yanray Wang <[email protected]>
yanrayw
added
enhancement
needs-review
yanrayw
changed the title
gilles-peskine-arm
approved these changes
Jan 20, 2023
Comment on lines
+763
to
+764
| # For Ubuntu 22.04, `Terminated` message is outputed by wait command. | ||
| # To remove it from stdout, redirect stdout/stderr to SRV_OUT |
There was a problem hiding this comment.
This comment applies only to wait, not to kill.
We get an error message from kill if the process has already crashes. Hiding it makes the output a little prettier, and the information is in the log file which we need to look at anyway, so I'm ok with that.
gilles-peskine-arm
added
needs-backports
Merged
3 tasks
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #6658
Gatekeeper checklist