Add warnings & disable PKCS #7 by default #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daverodgman
requested review from
gilles-peskine-arm,
tom-cosgrove-arm and
bensze01
Signed-off-by: Dave Rodgman <[email protected]>
daverodgman
force-pushed
the
pkcs7-docs
branch
from
08f882c to
bc5f03d
Compare
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
3 tasks
gilles-peskine-arm
previously approved these changes
Dec 1, 2022
There was a problem hiding this comment.
I wouldn't mind making the warning stronger, especially in mbedtls_config.h which I fear suggests only a verify-doesn't-enforce-all-policies kind of not ready, whereas we have a parser-risks-memory-corruption level of not ready. But I'm ok with the current wording.
tom-cosgrove-arm
previously approved these changes
Dec 1, 2022
tom-cosgrove-arm
added
approved
Co-authored-by: Tom Cosgrove <[email protected]> Signed-off-by: Dave Rodgman <[email protected]>
daverodgman
dismissed stale reviews from tom-cosgrove-arm and gilles-peskine-arm
via
dbcbf44
gilles-peskine-arm
approved these changes
Dec 5, 2022
|
The only CI failures are ABI compatibility, because PKCS 7 is now disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable PKCS 7 by default; add warnings to
mbedtls_config.handpkcs7.h.Also clarify documentation for
mbedtls_pkcs7_signed_xxx_verify()- this fixes #6692 .Gatekeeper checklist