Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Be explicit about constant time bignum functions that must take a 0 or 1 condition value #6212

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Backport 2.28: Be explicit about constant time bignum functions that must take a 0 or 1 condition value #6212

merged 1 commit into from
Aug 22, 2022

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Aug 18, 2022 •
edited
Loading

Backport of #6211

@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Aug 18, 2022
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Aug 18, 2022
Merged
2 tasks
@tom-cosgrove-arm tom-cosgrove-arm added the single-reviewer This PR qualifies for having only one reviewer label Aug 18, 2022
yanesca
yanesca approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tom-cosgrove-arm tom-cosgrove-arm added the approved Design and code approved - may be waiting for CI or backports label Aug 22, 2022
@tom-cosgrove-arm tom-cosgrove-arm removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Aug 22, 2022
@gilles-peskine-arm gilles-peskine-arm merged commit 250a612 into Mbed-TLS:mbedtls-2.28 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-cosgrove-arm @yanesca @gilles-peskine-arm