Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing break - backport 2.28 #6110

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add missing break - backport 2.28 #6110

merged 1 commit into from
Jul 21, 2022
+1 −0

Conversation

daverodgman
Copy link
Contributor

Trivial backport of #5952

@Zaya-dyno @daverodgman
Add missing break
e63492a 
In ''int execute_tests( int argc , const char ** argv )'' function,
switch case is missing break statement.

Signed-off-by: Tuvshinzaya Erdenekhuu <[email protected]>
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer component-test Test framework and CI scripts priority-low Low priority - this may not receive review soon labels Jul 20, 2022
@daverodgman daverodgman changed the title Add missing break Add missing break - backport 2.28 Jul 20, 2022
@daverodgman daverodgman mentioned this pull request Jul 20, 2022
Merged
4 tasks
@daverodgman daverodgman added the needs-ci Needs to pass CI tests label Jul 20, 2022
@tom-daubney-arm tom-daubney-arm self-requested a review July 20, 2022 18:12
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jul 20, 2022
tom-daubney-arm
tom-daubney-arm approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CI currently not complete however looks to be passing so far.

@tom-daubney-arm tom-daubney-arm removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Jul 21, 2022
@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports needs-preceding-pr Requires another PR to be merged first labels Jul 21, 2022
@daverodgman daverodgman merged commit 59dca4b into Mbed-TLS:mbedtls-2.28 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts needs-preceding-pr Requires another PR to be merged first priority-low Low priority - this may not receive review soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @tom-daubney-arm @Zaya-dyno