Backport 2.28: Disable debugging features in the primary code size measurement job #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The baremetal configuration includes debugging features whose size is not particularly interesting. Create a new preset for use when benchmarking code size which excludes debugging features that increase the size of non-debugging modules. Signed-off-by: Gilles Peskine <[email protected]>
In build_arm_none_eabi_gcc_m0plus, use baremetal_size instead of baremetal as the configuration, i.e. exclude debugging features. This job is the only one switching to baremetal_size because it's our primary point of reference for code size evolution, and which is the only job where we display the code size built with -Os so it's presumably the only job for which we really care about a meaningful code size report. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
enhancement
needs-review
| @@ -272,6 +272,24 @@ def baremetal_adapter(name, active, section): | |||
| return True | |||
| return include_in_full(name) and keep_in_baremetal(name) | |||
|
|
|||
| # This set contains options that are mostly for debugging or test purposes, | |||
| # and therefore should be excluded when doing code size measurements. | |||
| # Options that are their own module (such as MBEDTLS_CERTS_C and | |||
There was a problem hiding this comment.
I'm not sure about CERTS. Following the reasoning here, since it's its own module, I had it stay. But since it's only ever useful for the SSL integration tests and the baremetal config doesn't allow running them, maybe CERTS should be off? Or maybe it should be off in baremetal too?
There was a problem hiding this comment.
I would rather see it as potential baremetal improvement, not relevant to this PR. The rule you set is clear - modules stay as they are in the config.
AndrzejKurek
approved these changes
Mar 10, 2022
mprse
approved these changes
Mar 22, 2022
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4907. Identical except for a couple of options that exist in 2.28 but not in 3.x.