Backport 2.28: CMake: generate the list of test suites automatically #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep forgetting to register new test suites in tests/CMakeLists.txt. To fix this problem once and for all, remove the need for manual registration. The following test suites were missing: test_suite_cipher.aria test_suite_psa_crypto_driver_wrappers Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
enhancement
component-platform
gilles-peskine-arm
added
needs-review
AndrzejKurek
previously approved these changes
Jan 27, 2022
gilles-peskine-arm
changed the title
d3zd3z
previously approved these changes
Feb 2, 2022
mpg
added
approved
The race condition mentioned in the previous commit "Stop CMake out of source tests running on 16.04" has also been observed with test_cmake_as_subdirectory on 3.1 and can presumably happen on 2.28 as well. So skip it on Ubuntu 16.04 as well. Signed-off-by: Gilles Peskine <[email protected]>
This is no longer useful now that components run in a subshell. Signed-off-by: Gilles Peskine <[email protected]>
This is no longer useful now that components run in a subshell. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
dismissed stale reviews from d3zd3z and AndrzejKurek
via
d4c5c3d
This is now a no-op. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
removed
the
needs-reviewer
AndrzejKurek
approved these changes
Feb 4, 2022
d3zd3z
approved these changes
Feb 4, 2022
mpg
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5463. Similar code, but without the part about generated files.
The following test suites were missing:
I tested that the code works with CMake 2.8.12.2, which is the minimum version we require. Methodology: under Ubuntu 14.04,