Commit ssl_debug_helpers.h #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an automatically generated header file makes it harder to have working build scripts. The content of ssl_debug_helpers_generated.h isn't likely to change often, so we can update it manually. Signed-off-by: Gilles Peskine <[email protected]>
It's now under version control and meant to be updated manually. Signed-off-by: Gilles Peskine <[email protected]>
It's no longer generated, so rename it accordingly. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
needs-review
mpg
requested changes
Dec 16, 2021
Signed-off-by: Gilles Peskine <[email protected]>
davidhorstmann-arm
requested changes
Dec 16, 2021
| for start, instance in preprocess_c_source_code(source_code, EnumDefinition): | ||
| if start in definitions: | ||
| continue | ||
| if isinstance(instance, EnumDefinition): | ||
| definition, prototype = instance.generate_tranlation_function() | ||
| definition = instance.generate_tranlation_function() |
There was a problem hiding this comment.
Nit, preexisting: generate_tranlation_function() -> generate_translation_function() and in declaration etc.
There was a problem hiding this comment.
Preexisting, so I'm definitely not fixing it here. This is an urgent fix for the CI, not a general cleanup.
davidhorstmann-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a generated header file broke running
makefrom a fresh checkout. On the CI, this broke thecode-coveragejob (which we run nightly but not in PR). It didn't breakall.shbecause that currently always runsmake generated_filesbefore doing a build (for historical reasons, we'll change this at some point).This is a follow-up on #5329 which didn't actually solve the problem (it did with cmake, but not with make): it declared how to generate the header file, but in the makefile, we don't have dependencies on header files, so there was still nothing instructing to generate the header file.
The simplest solution is to not have an automatically generated header file. The content of that header file doesn't look hard to maintain manually, so I'm converting it to a manually updated file.
CI job with code-coverage → PASS
Only applicable to 3.x.