Return an error from mbedtls_cipher_set_iv for an invalid IV length with ChaCha20 and ChaCha20+Poly
#5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrzejKurek
added
mbed TLS team
needs-review
AndrzejKurek
force-pushed
the
chacha-iv-len-16-fixes
branch
from
c27cd42 to
72f0905
Compare
mprse
suggested changes
Jan 5, 2022
|
|
||
| ChaCha20 IV Length 12 | ||
| depends_on:MBEDTLS_CHACHA20_C | ||
| check_iv:MBEDTLS_CIPHER_CHACHA20:"CHACHA20":12:0 |
|
|
||
| if( cipher_info->type == MBEDTLS_CIPHER_CHACHA20 || | ||
| cipher_info->type == MBEDTLS_CIPHER_CHACHA20_POLY1305 ) | ||
| iv_len = 12; |
There was a problem hiding this comment.
I understand that 16 byes for iv is default (and max) length and for those two cipher types we are only limiting the length, but maybe we could first determine the iv length and then allocate memory?
There was a problem hiding this comment.
Done that :) It has an additional advantage as described in my comment below.
added 5 commits
January 14, 2022 16:31
The implementation was silently overwriting the IV length to 12 even though the caller passed a different value. Change the behavior to signal that a different length is not supported. Signed-off-by: Andrzej Kurek <[email protected]>
The implementation was silently overwriting the IV length to 12 even though the caller passed a different value. Change the behavior to signal that a different length is not supported. Signed-off-by: Andrzej Kurek <[email protected]>
Signed-off-by: Andrzej Kurek <[email protected]>
Signed-off-by: Andrzej Kurek <[email protected]>
Signed-off-by: Andrzej Kurek <[email protected]>
AndrzejKurek
force-pushed
the
chacha-iv-len-16-fixes
branch
from
4739eab to
b9fbc11
Compare
gabor-mezei-arm
requested changes
Jan 18, 2022
gabor-mezei-arm
removed
the
needs-reviewer
Signed-off-by: Andrzej Kurek <[email protected]>
gabor-mezei-arm
approved these changes
Jan 19, 2022
gabor-mezei-arm
removed
the
needs-review
AndrzejKurek
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mbedtls_cipher_set_ivwas silently overwritting theiv_lenset by the caller, thus leading to potential API misuse.Fixes #4301.