Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for the PSA Crypto API #5064

Closed
wants to merge 32 commits into from
Closed

Add examples for the PSA Crypto API #5064

wants to merge 32 commits into from

Conversation

hannestschofenig
Copy link
Contributor

Description

This PR contributes examples to help developers better understand the PSA Crypto API.

Status

IN DEVELOPMENT

Requires Backporting

NO

Migrations

NO

Additional comments

Any additional information that could be of interest

Todos

  • Documentation
  • Changelog updated

Steps to test or reproduce

Just run the educational examples

@hannestschofenig hannestschofenig mentioned this pull request Oct 19, 2021
Closed
@ronald-cron-arm ronald-cron-arm added component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-ci Needs to pass CI tests needs-work labels Oct 21, 2021
@mprse mprse self-requested a review October 27, 2021 08:19
@mprse
Copy link
Contributor

mprse commented Dec 1, 2021

What is current status of this PR?

@hannestschofenig
Copy link
Contributor Author

The status of this PR is the following: While I am still fine-tuning the examples I believe it should otherwise be ready for inclusion.

@gilles-peskine-arm
Copy link
Contributor

@hannestschofenig Thanks for these examples. But before we review, please fix the issues reported by the CI. Let us know if you need help understanding some of the errors.

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jan 27, 2022
Merged
@mprse mprse removed their request for review March 21, 2022 15:41
@daverodgman daverodgman added the priority-medium Medium priority - this can be reviewed as time permits label May 17, 2022
yuhaoth and others added 14 commits July 6, 2022 14:06
@yuhaoth
Add check read ptr macro
114a637 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
tls13: add key exchange modes in handshake params
69fc912 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
fix comments and check return issues
ecb6f7a 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
Address kex_modes check function
40c886f 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
fix doxygen parameter wrong
ea08571 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
fix document issues
837831e 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
fix check_name fail
881bf0a 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@yuhaoth
Improve document for chk_buf_read_ptr
5c8bb62 
Signed-off-by: Jerry Yu <[email protected]>
Signed-off-by: Hannes Tschofenig <[email protected]>
@hannestschofenig
Add examples for the PSA Crypto API
25e40a6 
Signed-off-by: Hannes Tschofenig <[email protected]>
@hannestschofenig
Update include files
7efae9e 
Signed-off-by: Hannes Tschofenig <[email protected]>
@hannestschofenig
Update CMakeLists.txt
56a7f00 
Signed-off-by: Hannes Tschofenig <[email protected]>
@hannestschofenig
Updated Makefile
09eb635 
... to build Visual Studio files

Signed-off-by: Hannes Tschofenig <[email protected]>
Fixing superfluous include
3f063e9 
Signed-off-by: Hannes Tschofenig <[email protected]>
@hannestschofenig
Using a random nonce
2aa9c78 
Signed-off-by: Hannes Tschofenig <[email protected]>
@tom-daubney-arm
Use correct format specifier in printf calls
25e6df4 
The psa_key_agreement program was using the %zu format
specifier which is not supported in mingw builds. The
library provides an MBEDTLS_PRINTF_SIZET macro in debug.h
for handling this situation.

Signed-off-by: Thomas Daubney <[email protected]>
@tom-daubney-arm tom-daubney-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-work needs-ci Needs to pass CI tests labels Oct 7, 2022
@tom-daubney-arm
Copy link
Contributor

All internal CI is passing. OpenCI errors are due to a known issue with the CI that is being worked on.

@hannestschofenig hannestschofenig mentioned this pull request Jan 10, 2023
Open
@tom-daubney-arm tom-daubney-arm mentioned this pull request May 16, 2023
Closed
daverodgman
daverodgman reviewed May 19, 2023
View reviewed changes
library/ssl_misc.h
@@ -713,6 +713,7 @@ struct mbedtls_ssl_handshake_params {
/*
* Handshake specific crypto variables
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental whitespace change?

@tom-daubney-arm tom-daubney-arm added needs-work needs-ci Needs to pass CI tests size-m Estimated task size: medium (~1w) and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jul 17, 2023
@tom-daubney-arm tom-daubney-arm mentioned this pull request Jul 18, 2023
Open
@tom-daubney-arm
Copy link
Contributor

tom-daubney-arm commented Jul 18, 2023 •
edited
Loading

This PR is now being split into a series of smaller PRs in order to make reviewing easier.

This series is summarised below with a check box to indicate when each PR has been merged.

PR Number Program Merged?
#7938 PSA Encrypt [ ]
#7942 PSA Hash [ ]
#7944 PSA HKDF [ ]
#7948 PSA Key Agreement [ ]
#7951 PSA MAC [ ]
#7953 PSA Random [ ]
#7954 PSA Sign Verify [ ]

This PR will be closed now since it is superseded by the new series of PRs.

@tom-daubney-arm tom-daubney-arm marked this pull request as draft July 18, 2023 12:36
This was referenced Jul 18, 2023
Merged
Open
Open
Open
Open
Open
@tom-daubney-arm
Copy link
Contributor

I am now closing this PR since it has been broken down in to series of smaller PRs, as per this comment.

This was referenced Jul 22, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daverodgman daverodgman daverodgman left review comments

Assignees

@tom-daubney-arm tom-daubney-arm

Labels
component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement historical-reviewed Reviewed & agreed to keep legacy PR/issue needs-ci Needs to pass CI tests needs-work priority-medium Medium priority - this can be reviewed as time permits size-m Estimated task size: medium (~1w)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hannestschofenig @mprse @gilles-peskine-arm @tom-daubney-arm @daverodgman @ronald-cron-arm @tom-cosgrove-arm @yuhaoth