Remove MBEDTLS_SSL_EXPORT_KEYS, making it always on #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2021 10:15
This option only gated an ability to set a callback, but was deemed unnecessary as it was yet another define to remember when writing tests, or test configurations. Fixes Mbed-TLS#4653. Signed-off-by: Andrzej Kurek <[email protected]>
When not using DEBUG_C, but using the DTLS CID feature - a null pointer was accessed in ssl_tls.c. Signed-off-by: Andrzej Kurek <[email protected]>
AndrzejKurek
force-pushed
the
remove-ssl-export-keys
branch
from
db07234 to
324f72e
Compare
Signed-off-by: Andrzej Kurek <[email protected]>
AndrzejKurek
force-pushed
the
remove-ssl-export-keys
branch
from
3308774 to
a72fe64
Compare
AndrzejKurek
added
Product Backlog
enhancement
component-tls
needs-review
AndrzejKurek
added
size-s
davidhorstmann-arm
approved these changes
Oct 4, 2021
AndrzejKurek
added
needs-ci
|
I believe the failures are related to the ongoing CI issue. |
davidhorstmann-arm
added
approved
| make | ||
|
|
||
| msg "test: Connection ID enabled, debug disabled" | ||
| make test |
There was a problem hiding this comment.
Is this actually a non-regression test? In 2.28, the bug (which I'll fix in #5730) isn't triggered by unit tests, only by compat.sh.
There was a problem hiding this comment.
It is a non-regression test in 3.x. Without the bug fix:
Test moving clients handshake to state: CLIENT_CHANGE_CIPHER_SPEC . Segmentation fault (core dumped)
On the other hand, in 2.28, test_suite_ssl passes in this configuration, even though the corresponding test exists. I don't know why. The level of support for CID looks the same in both branches.
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this pull request
Apr 13, 2022
The fix was in Mbed-TLS#4989. We forgot to add a changelog entry. Signed-off-by: Gilles Peskine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option only gated an ability to set a callback, but was deemed unnecessary as it was yet another define to remember when writing tests, or test configurations.
Fixes #4653.
Fixes #3998.