Backport 2.16: Add Free context at the end of aes_crypt_xts_size() #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in file tests/suite/test_suite_aes.function, aes_crypt_xts_size() did not free the context upon the function exit. The function now frees the context on exit. Already resolved for 2.x and development - this is a backport for 2.16 Fixes Mbed-TLS#4176 Signed-off-by: JoeSubbiani <[email protected]>
JoeSubbiani
added
bug
fix available
needs-review
2 tasks
JoeSubbiani
changed the title
JoeSubbiani
changed the title
2 tasks
Signed-off-by: Joe Subbiani <[email protected]>
The original formatting was in dos and the changelog assembler would fail. The length of the description was too long horizontally. This has been updated. Signed-off-by: Joe Subbiani <[email protected]>
daverodgman
requested changes
Jun 18, 2021
ChangeLog.d/issue4176.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| Bugfix | |||
| * Fix an issue where resource is never freed when running one particular | |||
| test suite with an alternative AES implementation. Fixes #4176 | |||
Trailing white space causing check_files.py to fail issue4176.txt was also in dos format - this has been changed to unix Signed-off-by: Joe Subbiani <[email protected]>
JoeSubbiani
force-pushed
the
2.16FixedMissingContextFree
branch
from
a4f0249 to
dcdb277
Compare
daverodgman
added
needs-work
and removed
needs: changelog
needs-review
Missing trailing full stop added to the end of the fixed issue number Signed-off-by: Joe Subbiani <[email protected]>
- “Fix an issue where X happens” → ”Fix X“ the extra words are just a distraction. - “resource” → “a resource” - “where resource is never freed” has a name: it's a resource leak - “when running one particular test suite” → “in a test suite” Signed-off-by: Joe Subbiani <[email protected]>
gilles-peskine-arm
approved these changes
Jun 21, 2021
gilles-peskine-arm
added
needs-review
daverodgman
approved these changes
Jun 21, 2021
daverodgman
removed
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in file tests/suite/test_suite_aes.function, aes_crypt_xts_size()
did not free the context upon the function exit.
The function now frees the context on exit.
This modification has also taken place in:
Closes #4176
Status
READY
Requires Backporting
When there is a bug fix, it should be backported to all maintained and supported branches.
Changes do not have to be backported if:
NO
There is already a backport for 2.x, and the change has been made on 2.16 (here) and the development branch
Migrations
NO
Todos
Steps to test or reproduce
test_suite_aes