Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply 4334 to development-3.0 #4349

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Apr 15, 2021

#4334 was merged in development instead of development_3.0 by mistake, this is a revival of it now targeting the correct branch :)

I rebased the over development_3.0 but kept the same commit structure, in order to make it easy to check that this indeed equivalent to the original using something like git range-diff development..public/pr/4334 development_3.0..public/pr/4349 (after checking that the command is correct and adapting names to your local setup).

Fixes #4280

@mpg mpg added the mbedtls-3 label Apr 15, 2021
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 15, 2021
@bensze01
Copy link
Contributor

Do we need to merge this after the original commit-revert pair has been merged into development_3.0?
Or will that not cause any issues / will we fix those issues during the next merge?

@bensze01 bensze01 linked an issue Apr 16, 2021 that may be closed by this pull request
@mpg mpg added the needs-preceding-pr Requires another PR to be merged first label Apr 16, 2021
@mpg
Copy link
Contributor Author

mpg commented Apr 16, 2021

Good question, I'm not sure. I would expect git merge to do the right think, but I wouldn't be overly surprised if it didn't. Probably safer to wait for the next merge of development there, then. I'm labeling "needs: preceding PR" to reflect that.

@bensze01
Copy link
Contributor

#4366 was merged, so I'm removing the needs: preceding PR label.

@bensze01 bensze01 removed the needs-preceding-pr Requires another PR to be merged first label Apr 19, 2021
@mpg
Copy link
Contributor Author

mpg commented Apr 22, 2021

Considering this is a straightforward port of a PR that was previously approved, this only needs a single approval.

@mpg mpg removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 22, 2021
@mpg
Copy link
Contributor Author

mpg commented Apr 22, 2021

The CI is passing except the API-ABI break check which is expected to fail, and the PR is targeting the 3.0 branch.

@mpg mpg added the approved Design and code approved - may be waiting for CI or backports label Apr 22, 2021
@mpg mpg merged commit f6b677e into Mbed-TLS:development_3.0 Apr 22, 2021
@mpg mpg deleted the apply-4334-3.0 branch April 22, 2021 11:04
daverodgman pushed a commit that referenced this pull request Apr 23, 2021
Apply 4334 to development-3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove superseded/deprecated functions from hashing modules
4 participants