-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply 4334 to development-3.0 #4349
Conversation
Signed-off-by: TRodziewicz <[email protected]>
Signed-off-by: TRodziewicz <[email protected]>
Signed-off-by: TRodziewicz <[email protected]>
Signed-off-by: TRodziewicz <[email protected]>
Do we need to merge this after the original commit-revert pair has been merged into development_3.0? |
Good question, I'm not sure. I would expect |
#4366 was merged, so I'm removing the |
Considering this is a straightforward port of a PR that was previously approved, this only needs a single approval. |
The CI is passing except the API-ABI break check which is expected to fail, and the PR is targeting the 3.0 branch. |
Apply 4334 to development-3.0
#4334 was merged in development instead of development_3.0 by mistake, this is a revival of it now targeting the correct branch :)
I rebased the over development_3.0 but kept the same commit structure, in order to make it easy to check that this indeed equivalent to the original using something like
git range-diff development..public/pr/4334 development_3.0..public/pr/4349
(after checking that the command is correct and adapting names to your local setup).Fixes #4280