Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7: Fix potential memory leak in EC multiplication #3353

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Backport 2.7: Fix potential memory leak in EC multiplication #3353

merged 3 commits into from
Jun 5, 2020

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented May 25, 2020 •
edited by mpg
Loading

This is the 2.7 backport of #3318

@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces labels May 25, 2020
@gilles-peskine-arm gilles-peskine-arm self-assigned this May 25, 2020
@tiod4420 tiod4420 mentioned this pull request May 25, 2020
Merged
mpg
mpg previously approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a faithful backport of the original, and it has the same typo in the PR number in the ChangeLog.

@gilles-peskine-arm gilles-peskine-arm force-pushed the fix-ecp-mul-memory-leak-2.7 branch from 2ab27a3 to 701063b Compare June 4, 2020 11:39
@gilles-peskine-arm gilles-peskine-arm requested a review from mpg June 4, 2020 11:40
ronald-cron-arm
ronald-cron-arm approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fair backport of bug fix.

@mpg mpg removed the needs-review Every commit must be reviewed by at least two team members, label Jun 5, 2020
@mpg mpg merged commit 1539d15 into Mbed-TLS:mbedtls-2.7 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@mpg mpg mpg approved these changes

Assignees

@gilles-peskine-arm gilles-peskine-arm

Labels
bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilles-peskine-arm @mpg @ronald-cron-arm @tiod4420