Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for win2k #3239

Merged
merged 1 commit into from
May 4, 2020
Merged

add support for win2k #3239

merged 1 commit into from
May 4, 2020

Conversation

opatomic
Copy link
Contributor

Description

getaddrinfo() is not available on win2k. By including wspiapi.h (if _WIN32_WINNT is defined as value < 0x0501) then a compatibility layer will be used when running on win2k. For more details, refer to Microsoft docs for getaddrinfo().

Status

READY

Requires Backporting

NO

Migrations

NO

Steps to test or reproduce

Define _WIN32_WINNT as 0x0500, build, run on win2k VM. If you are cross compiling from linux to windows here's a sequence of commands to do this:

sudo apt-get install mingw-w64
CC=i686-w64-mingw32-gcc AR=i686-w64-mingw32-ar CFLAGS="-D_WIN32_WINNT=0x0500" LDFLAGS="-lws2_32" make

getaddrinfo() is not available on win2k. By including wspiapi.h (if
_WIN32_WINNT is defined as value < 0x0501) then a compatibility layer
will be used when running on win2k. For more details, refer to Microsoft
docs for getaddrinfo().

Signed-off-by: opatomic <[email protected]>
@danh-arm danh-arm added enhancement needs-review Every commit must be reviewed by at least two team members, labels Apr 27, 2020
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpg mpg self-requested a review May 4, 2020 10:05
@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels May 4, 2020
@mpg mpg removed their request for review May 4, 2020 10:19
@mpg mpg merged commit 1d632c2 into Mbed-TLS:development May 4, 2020
@opatomic opatomic deleted the win2kdns branch June 1, 2020 23:53
@opatomic opatomic restored the win2kdns branch June 1, 2020 23:54
yanesca added a commit that referenced this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants