Remove error_description variable from strerr functions

[aggarg]

Description

The definition of the newly added functions mbedtls_high_level_strerr and mbedtls_low_level_strerr were of the form:

const char * mbedtls_high_level_strerr( int error_code )
{
    const char * error_description = NULL;

    switch( error_code )
    {
        case -(MBEDTLS_ERR_X509_FILE_IO_ERROR):
            error_description = "X509 - Read/write of file failed";
            break;

        default:
            break;
    }

    return error_description;
}

As suggested on this PR: #3176, we can remove the use of error_description variable:

const char * mbedtls_high_level_strerr( int error_code )
{
    switch( error_code )
    {
        case -(MBEDTLS_ERR_X509_FILE_IO_ERROR):
            return "X509 - Read/write of file failed";

        default:
            break;
    }

    return NULL;
}

This PR implements the suggestion.

Status

READY

Requires Backporting

NO

Signed-off-by: Gaurav Aggarwal [email protected]

[irwir]

Looks good, but one change would be requested by reviewers - additional parentheses with spaces around returned value as said in local coding standards description.
In your example It should have been:
return( "X509 - Read/write of file failed" );
return( NULL );.

[aggarg]

Looks good, but one change would be requested by reviewers - additional parentheses with spaces around returned value as said in local coding standards description.
In your example It should have been:
return( "X509 - Read/write of file failed" );
return( NULL );.

Good point. Will address.

[ronald-cron-arm]

Thanks for this contribution, LGTM. 2 approvals and the CI is ok thus labelling this PR as ready for merge.