Saving the serialized context to a file #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patater
suggested changes
Apr 17, 2020
programs/ssl/ssl_client2.c
Outdated
| @@ -516,6 +523,9 @@ struct options | |||
| * during renegotiation */ | |||
| const char *cid_val; /* the CID to use for incoming messages */ | |||
| int serialize; /* serialize/deserialize connection */ | |||
| const char *serial_to_file; /* the file to write a serialized connection | |||
| * in the form of base64 code ( serialize | |||
There was a problem hiding this comment.
Style: don't need spaces after ( in comments.
programs/ssl/ssl_client2.c
Outdated
| " serialize=%%d default: 0 (do not serialize/deserialize)\n" \ | ||
| " options: 1 (serialize)\n" \ | ||
| " 2 (serialize with re-initialization)\n" \ | ||
| " serial_to_file=%%s The file path to write a serialized connection\n"\ |
There was a problem hiding this comment.
Could we rename this to "context_file"? "Serial to file" doesn't make very much sense in English.
There was a problem hiding this comment.
Yes, I know. I wanted to use an abbreviation instead of a full word like for example 'renego' instead of 'renegotiation' :). I changed to 'context_file'
Signed-off-by: Piotr Nowicki <[email protected]>
piotr-now
force-pushed
the
serialized_to_file
branch
from
20b35ed to
8ea0f48
Compare
|
Added missing mbedtls_free to fix CI failure |
Patater
previously approved these changes
Apr 17, 2020
Signed-off-by: Piotr Nowicki <[email protected]>
piotr-now
force-pushed
the
serialized_to_file
branch
from
8ea0f48 to
3de298f
Compare
danh-arm
added
enhancement
needs-review
Patater
approved these changes
Apr 20, 2020
dgreen-arm
approved these changes
Apr 20, 2020
Patater
removed
the
needs-review
|
CI passing, other than Mbed OS known issue which is being addressed separately. Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Nowicki [email protected]
Description
This PR adds in the ssl_server2 and ssl_client2 programs the ability to save a serialized context to a file as base64 code.
Status
READY
Requires Backporting
NO