Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GRMP-56] Systest Failure: 'test_chunked_download'. #3

Closed
wants to merge 2 commits into from
Closed

[GRMP-56] Systest Failure: 'test_chunked_download'. #3

wants to merge 2 commits into from

Conversation

HemangChothani
Copy link
Collaborator

@HemangChothani HemangChothani commented Jul 18, 2019 •
edited by mf2199
Loading

Addresses GRMP-56

  • fix syntax error, Due to system tests run with different versions of python

mf2199
mf2199 reviewed Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to run the test after the update? Does it pass?

@HemangChothani
Copy link
Collaborator Author

HemangChothani commented Jul 23, 2019 •
edited
Loading

Yes test_chunk_download system test pass and it doesn't affect other test-cases , though others also fails in master branch and for that i found separate task.

@MaxxleLLC MaxxleLLC force-pushed the fix/test_failure_chunked_download_gzipped_content_56 branch from 32cb26d to 87c2f01 Compare July 26, 2019 07:15
@mf2199 mf2199 changed the title system test cunk download and syntax error/56 [GRMP-56] Systest Failure: 'test_chunked_download'. Jul 31, 2019
@mf2199 mf2199 self-requested a review July 31, 2019 17:54
mf2199
mf2199 requested changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise your solution as per @tseaver comments.

@HemangChothani
Copy link
Collaborator Author

HemangChothani commented Aug 1, 2019 •
edited
Loading

The problem is from the back-end side that header is missing which i mentioned earlier and the solution which @tseaver is asking for that i have implemented in Public Pull Request 85 .Need some clarification on response.raw which he wants to implement that i have done in _write_to_stream method and already tested in system test.

@mf2199 mf2199 closed this Aug 5, 2019
@mf2199
Copy link
Collaborator

mf2199 commented Aug 5, 2019 •
edited
Loading

Closed by error. Reopening.

@mf2199 mf2199 reopened this Aug 5, 2019
@mf2199
Copy link
Collaborator

mf2199 commented Aug 7, 2019

The problem is from the back-end side that header is missing which i mentioned earlier and the solution which @tseaver is asking for that i have implemented in Public Pull Request 85 .Need some clarification on response.raw which he wants to implement that i have done in _write_to_stream method and already tested in system test.

I'd consult @tseaver about it.

@mf2199 mf2199 requested review from emar-kar and IlyaFaer August 13, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2199 mf2199 mf2199 requested changes

@emar-kar emar-kar Awaiting requested review from emar-kar

@IlyaFaer IlyaFaer Awaiting requested review from IlyaFaer

Assignees
No one assigned
Labels
build type: process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HemangChothani @mf2199