Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bigquery): update code samples and move to own sample file #98

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

refactor(bigquery): update code samples and move to own sample file #98

wants to merge 3 commits into from

Conversation

HemangChothani
Copy link
Collaborator

@HemangChothani HemangChothani commented Jan 16, 2020 •
edited
Loading

Towards [8989]

List of changes:

New samples:

  1. load_table_*
  2. extract_table*
  3. get_job
  4. cancel_job
  5. create_table_cmek
  6. client_query_total_rows
  7. list_rows_as_dataframe
  8. query_results_as_dataframe
  9. query_external_gcs_permanent_table
  10. update_table*
  11. create_view*
  12. get_view
  13. grant_access_view
  14. update_table_expiration
  15. relax_column
  16. create_partitioned_table

@IlyaFaer
Copy link
Collaborator

Whoa, it's too many changes. We agreed with Tim Swast, that we'll be pushing the samples in portions: five samples per PR

@HemangChothani
Copy link
Collaborator Author

@IlyaFaer ok sure i will do that.

mf2199
mf2199 requested changes Jan 20, 2020
View reviewed changes
Copy link
Collaborator

@mf2199 mf2199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Are you doing this by hand or using a script?

bigquery/samples/tests/test_load_table_file.py
# limitations under the License.

import os
from google.cloud import bigquery
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either, add a blank line here or remove blank lines elsewhere to maintain formatting consistency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mf2199 By hand as need to change few things and also have to add few assertion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mf2199 mf2199 mf2199 requested changes

@IlyaFaer IlyaFaer Awaiting requested review from IlyaFaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HemangChothani @IlyaFaer @mf2199