forked from googleapis/google-cloud-python
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: deprecate client.dataset()
part 10
#52
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync forks
*.rst + *.py + test + conf +
Methods were divided into 3 files: - add label - get labels - delete labels *.rst - docs updated tests passed successfully
minor corrections, 'dataset_exists' moved to the 'Getting a Dataset' section
minor corrections, 'dataset_exists' moved to the 'Getting a Dataset' section
grammar fix
grammar fix
minor corrections, removed extra comments
minor corrections, removed extra comments
deleted 'dataset_exists' and 'table_exists' methods
Added additional asserts into the test + refactoring of the main file.
cosmetic chgs by 'black'
Chged an assertion parameter
* fixed assertion error by removing incorrect assertion statements.
* moved some functionality into 'conftest' with the new fixture
merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three snippets (full list):