-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQueryDataTransfer [GCP-7722] : add documentation for param paramter #51
base: master
Are you sure you want to change the base?
BigQueryDataTransfer [GCP-7722] : add documentation for param paramter #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, although this doesn't seem to be wrong, I'm not sure whether this is what they would expect to see in the API Documentation. It is possible that the author meant more of a verbal explanation rather than a code snippet. We may need a consensus from more reviewers, so I've asked @IlyaFaer , @emar-kar , and @sumit-ql to share their opinions as well.
First of all, we should not make any changes in the _pb2.py file. These are autogenerated. Now, another thing is, are we allowed to make changes in proto files, i am not sure about it. May be Alex can tell us if we are allowed to modify the proto files as they are super sensitive. |
@sumit-ql 👍 |
@sumit-ql thanks, even i forgot about the proto files. We are not allowed to make changes in proto files,once i did and #tres refused me, only they are allowed to do that. |
Something worth bringing up during our next Google meeting. |
IPR 7722