[GCP-5538] Storage: Missing support for HTTP Headers and Query String Parameters #17
Conversation
HemangChothani
changed the title
mf2199
changed the title
| blob_or_uri.download_to_file(file_obj, client=self, start=start, end=end) | ||
| blob_or_uri.download_to_file( | ||
| file_obj, client=self, start=start, end=end, query_params=query_params | ||
| ) |
There was a problem hiding this comment.
This repeats lines 402-404. Is there any way to check the type and validate the blob_or_uri parameter before the try...except clause and avoid an unnecessary API call?
There was a problem hiding this comment.
I have only added query_params parameter not added try..except and is it fine to change their usecase?
There was a problem hiding this comment.
It should be fine as long as two API calls were there initially, I just thought we could improve on that too, along the way.
| client=client, | ||
| start=start, | ||
| end=end, | ||
| query_params=query_params, |
There was a problem hiding this comment.
Remove the extra "comma" after query params.
There was a problem hiding this comment.
if i remove "comma" than blacken test failed, you can see also in client.py that added "comma" after client parameter
| client=client, | ||
| start=start, | ||
| end=end, | ||
| query_params=query_params, |
There was a problem hiding this comment.
Same as above
| size, | ||
| num_retries, | ||
| predefined_acl, | ||
| extra_headers, |
There was a problem hiding this comment.
same as above
|
Yes , i did that, but i followed docs url where i found |
| blob_or_uri.download_to_file(file_obj, client=self, start=start, end=end) | ||
| blob_or_uri.download_to_file( | ||
| file_obj, client=self, start=start, end=end, query_params=query_params | ||
| ) |
There was a problem hiding this comment.
It should be fine as long as two API calls were there initially, I just thought we could improve on that too, along the way.
Addressing #5538