Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): fix incorrect mtime by UTC offset #106

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(storage): fix incorrect mtime by UTC offset #106

wants to merge 2 commits into from

Conversation

HemangChothani
Copy link
Collaborator

@HemangChothani HemangChothani commented Jan 29, 2020 •
edited by IlyaFaer
Loading

IPR [10214]

IlyaFaer
IlyaFaer approved these changes Jan 29, 2020
View reviewed changes
Copy link
Collaborator

@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

storage/google/cloud/storage/_helpers.py


def _convert_to_timestamp(value):
"""Convert non-none datetime to timestamp.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-None, I believe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyaFaer yes agree, but here they have used lowercase in whole file so i didn't change it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with both of you. While certainly grammatically incorrect, we might want to make no changes and let this to be dealt with later.

MaxxleLLC
MaxxleLLC approved these changes Jan 29, 2020
View reviewed changes
Copy link
Owner

@MaxxleLLC MaxxleLLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

storage/google/cloud/storage/_helpers.py


def _convert_to_timestamp(value):
"""Convert non-none datetime to timestamp.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with both of you. While certainly grammatically incorrect, we might want to make no changes and let this to be dealt with later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxxleLLC MaxxleLLC MaxxleLLC approved these changes

@IlyaFaer IlyaFaer IlyaFaer approved these changes

@mf2199 mf2199 Awaiting requested review from mf2199

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HemangChothani @IlyaFaer @MaxxleLLC