-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
import android.widget.TextView | ||
|
||
class IncorrectSongsScreen : AppCompatActivity() { | ||
override fun onCreate(savedInstanceState: Bundle?) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method onCreate
has 29 lines of code (exceeds 25 allowed). Consider refactoring.
val intent = Intent(this, GameEndingScreen::class.java) | ||
//MOCK VALUES FOR INCORRECT SONGS, ADAPT FROM GAME DATA IN THE FUTURE | ||
val incArray: Array<String> = arrayOf("One", "Two", "Three") | ||
val statNames: Array<String> = arrayOf("Hello there", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
"Third Stat", | ||
"Fourth Stat", | ||
"Fifth Stat") | ||
val statRes: Array<String> = arrayOf("General Kenobi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
|
||
} | ||
|
||
fun switchBackToWelcome(view: View) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some refactoring is needed to fix codeclimate issues but we can refactor these as next weeks tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! but you should really add the doc soon ! (and clean all commented code)
import android.widget.LinearLayout.* | ||
import android.widget.TextView | ||
|
||
class IncorrectSongsScreen : AppCompatActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc would be great
import android.view.View | ||
import android.widget.* | ||
|
||
class GameEndingScreen : AppCompatActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc too ?
|
||
|
||
val playerNameView: TextView = findViewById(R.id.end_player_name) | ||
val statPlayerText = "Here are the stats for the player $playerName" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard coded text
Code Climate has analyzed commit 8de5b70 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 92.9% (1.0% change). View more on Code Climate. |
Added two activies to show users how they performed in a game: