-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave a comment but the rest LGTM.
Don't forget to resolve the conflicts before merging.
android:gravity="center" | ||
app:layout_constraintBottom_toTopOf="@+id/buzzersLayout" | ||
app:layout_constraintBottom_toTopOf="@+id/answer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using a more specific id instead of "answer", we will probably have a lot of them since we have multiple games.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Happy you could resolve the issue. Don't forget the conflicts!
Code Climate has analyzed commit 1b4afbc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.1% (1.1% change). View more on Code Climate. |
No description provided.