Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

margaux/popup-fix #85

Merged
merged 10 commits into from
Mar 17, 2022
Merged

margaux/popup-fix #85

merged 10 commits into from
Mar 17, 2022

Conversation

zwierski
Copy link
Collaborator

No description provided.

@zwierski zwierski marked this pull request as ready for review March 17, 2022 15:56
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave a comment but the rest LGTM.
Don't forget to resolve the conflicts before merging.

android:gravity="center"
app:layout_constraintBottom_toTopOf="@+id/buzzersLayout"
app:layout_constraintBottom_toTopOf="@+id/answer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using a more specific id instead of "answer", we will probably have a lot of them since we have multiple games.

Copy link
Collaborator

@kamilababayeva kamilababayeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Happy you could resolve the issue. Don't forget the conflicts!

@codeclimate
Copy link

codeclimate bot commented Mar 17, 2022

Code Climate has analyzed commit 1b4afbc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.1% (1.1% change).

View more on Code Climate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants