Jwen/show lyric

[jiabaow]

Show lyrics of the request (track, artist) Remove activities that are already linked in the welcome screen from the greeting screen

[MaximeZmt]

First reading looks good, just missing some documentation for non temporary code.
I will do a second read (and more in depth) later

[laurislopata]

LGTM

[kamilababayeva]

Do you think the logic of fetching data should be left in activity or moved somewhere else?

[jiabaow]

I agree that way will be more consistent with the existing code we have, but from all the examples I have seen using retrofit they all put it like this.

[kamilababayeva]

I was also fetching data. I did not use retrofit, I used okhttp3 and android.net.uri to build uri. I followed Maxime's logic in ItunesMusicApi.kt. He has created a class for fetching data with callbacks in it. So, when there was a click on the button, he just called this class to fetch data. I am not saying it is correct, but I liked that there is some separation.

[kamilababayeva]

We can keep the way you did!

[codeclimate]

Code Climate has analyzed commit c399a02 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.9% (80% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

[Tsathogguaa]

Looks good to me. You have a few hardcoded strings that can be changed, as well as concatenating texts inside "setText" according to the CI warnings, but those can be fixed in future PRs along with other warnings we get. Good work!

[jiabaow]

Looks good to me. You have a few hardcoded strings that can be changed, as well as concatenating texts inside "setText" according to the CI warnings, but those can be fixed in future PRs along with other warnings we get. Good work!

Thanks for the comments, I leave them hardcoded because they're temporary for showing the lyric, we need to change them later