Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Moved the button up #6

Merged
merged 7 commits into from
Mar 3, 2022
Merged

Moved the button up #6

merged 7 commits into from
Mar 3, 2022

Conversation

laurislopata
Copy link
Collaborator

No description provided.

jiabaow
jiabaow suggested changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, but I saw some configurations in ./idea changed, which should not be the case (normally)

MaximeZmt
MaximeZmt approved these changes Mar 3, 2022
View reviewed changes
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .Idea difference, update .gitignore to avoid changing it every time

Now pass the CI

@MaximeZmt MaximeZmt closed this Mar 3, 2022
@MaximeZmt MaximeZmt reopened this Mar 3, 2022
jiabaow
jiabaow approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaximeZmt MaximeZmt merged commit a623882 into main Mar 3, 2022
@MaximeZmt MaximeZmt deleted the bugfix/moved-button-up branch March 3, 2022 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaximeZmt MaximeZmt MaximeZmt approved these changes

@jiabaow jiabaow jiabaow approved these changes

@Tsathogguaa Tsathogguaa Awaiting requested review from Tsathogguaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurislopata @jiabaow @MaximeZmt