Tsathogguaa/welcome #48
Conversation
Tsathogguaa
requested review from
jiabaow,
MaximeZmt,
kamilababayeva,
laurislopata and
zwierski
Tsathogguaa
removed request for
laurislopata,
zwierski,
kamilababayeva,
jiabaow and
MaximeZmt
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -31,4 +32,9 @@ class MainActivity : AppCompatActivity() { | |||
| startActivity(scoreboardIntent) | |||
| } | |||
| } | |||
|
|
|||
| fun switchToWelcome(view: View) { | |||
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| setContentView(R.layout.activity_welcome_screen) | ||
| } | ||
|
|
||
| fun switchToPlay(view: View) { |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| startActivity(intent) | ||
| } | ||
|
|
||
| fun switchToProfile(view: View) { //FILLER INTENT |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| startActivity(intent) | ||
| } | ||
|
|
||
| fun switchToScoreboard(view: View) { |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| startActivity(intent) | ||
| } | ||
|
|
||
| fun switchToListen(view: View) { //FILLER INTENT |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| startActivity(intent) | ||
| } | ||
|
|
||
| fun switchToSettings(view: View) { //FILLER INTENT |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
Tsathogguaa
requested review from
MaximeZmt,
jiabaow,
kamilababayeva,
laurislopata and
zwierski
Tsathogguaa
requested review from
MaximeZmt,
kamilababayeva,
laurislopata and
zwierski
and removed request for
MaximeZmt,
jiabaow,
laurislopata and
zwierski
There was a problem hiding this comment.
Good job on the welcome screen and game setup screen!
Maybe try to reduce the code duplications indicated by the CI, use @string for the strings instead of hardcode them and remove the commented code blocks (or add some documentation explaining why they are in comment)
You can also put a Screenshot of the UI in the PR description. I might be too curious but it will be nice to see them ;)
| intended(hasComponent(GameSetupScreen::class.java.name)) | ||
| } | ||
|
|
||
| /*@Test |
There was a problem hiding this comment.
why this test is in the comments?
There was a problem hiding this comment.
I removed a button that was causing problems, as it wasn't fitting in whatever emulator they are using for the CI tests. It all passed locally until then. This test is for that button, since it doesn't exist for now, I removed it, however am thinking of readding it in some form.
|
Code Climate has analyzed commit ee6882a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.6% (80% is the threshold). This pull request will bring the total coverage in the repository to 99.2% (-0.7% change). View more on Code Climate. |
Added the welcome screen and game setup screen which allows anywhere from one to four people to play together.
