This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
fix ending buzzer v1 #371
Merged
fix ending buzzer v1 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -297,7 +301,16 @@ class BuzzerScreenActivity : GameActivity() { | |||
| checkAndStopPlayer(gameManager) | |||
| val intent = Intent(this, GameEndingActivity::class.java) | |||
|
|
|||
| //TODO put extras to display in GameEndingActivity | |||
| //Set list of incorrect songs | |||
| val incorrectSongList: ArrayList<String> = ArrayList( | |||
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| intent.putStringArrayListExtra("incorrectSongList", incorrectSongList) | ||
|
|
||
| //Set list of correct songs | ||
| val correctSongList: ArrayList<String> = ArrayList( |
There was a problem hiding this comment.
Similar blocks of code found in 4 locations. Consider refactoring.
| arrayListOf(R.id.end_stat1, R.id.end_stat2, R.id.end_stat3, R.id.end_stat4) | ||
| arrayListOf(R.id.end_stat0, R.id.end_stat1, R.id.end_stat2, R.id.end_stat3) | ||
|
|
||
| private val nameIds = arrayListOf(R.id.name_0, R.id.name_1, R.id.name_2, R.id.name_3) |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| arrayListOf(R.id.end_stat0, R.id.end_stat1, R.id.end_stat2, R.id.end_stat3) | ||
|
|
||
| private val nameIds = arrayListOf(R.id.name_0, R.id.name_1, R.id.name_2, R.id.name_3) | ||
| private val scoreIds = arrayListOf(R.id.score_0, R.id.score_1, R.id.score_2, R.id.score_3) |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit bba4946 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 99.4% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.3% (0.2% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: