Refactoring remove duplication

[jiabaow]

No description provided.

[codeclimate]

Code Climate has analyzed commit e9e9634 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 83.1% (80% is the threshold).

This pull request will bring the total coverage in the repository to 83.8%.

View more on Code Climate.

[MaximeZmt]

Nice work !!! 👍

I've spotted a bug when playing with the adding/remove friends feature. It seems not created by your code but can you have a look at it if you have some time 😅

Here is the stacktrace

E/AndroidRuntime: FATAL EXCEPTION: main
Process: ch.sdp.vibester, PID: 30965
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
at java.util.ArrayList.get(ArrayList.java:437)
at ch.sdp.vibester.helper.GameManager.setGameSongList(GameManager.kt:50)
at ch.sdp.vibester.fragment.GameSetupFragment.setGameSongList(GameSetupFragment.kt:217)
at ch.sdp.vibester.fragment.GameSetupFragment.chooseGenre(GameSetupFragment.kt:273)
at ch.sdp.vibester.fragment.GameSetupFragment.chooseGenre$default(GameSetupFragment.kt:253)
at ch.sdp.vibester.fragment.GameSetupFragment.chooseGame(GameSetupFragment.kt:239)
at ch.sdp.vibester.fragment.GameSetupFragment.setGenreListeners$lambda-2(GameSetupFragment.kt:87)
at ch.sdp.vibester.fragment.GameSetupFragment.$r8$lambda$KHwOr6KrbnnsD0c8aXctbLKYlwk(Unknown Source:0)
at ch.sdp.vibester.fragment.GameSetupFragment$$ExternalSyntheticLambda7.onClick(Unknown Source:2)
at android.view.View.performClick(View.java:7792)
at android.widget.TextView.performClick(TextView.java:16045)
at android.view.View.performClickInternal(View.java:7769)
at android.view.View.access$3800(View.java:910)
at android.view.View$PerformClick.run(View.java:30184)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8582)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)

[laurislopata]

LGTM

[jiabaow]

Nice work !!! 👍

I've spotted a bug when playing with the adding/remove friends feature. It seems not created by your code but can you have a look at it if you have some time 😅

Here is the stacktrace

E/AndroidRuntime: FATAL EXCEPTION: main Process: ch.sdp.vibester, PID: 30965 java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.get(ArrayList.java:437) at ch.sdp.vibester.helper.GameManager.setGameSongList(GameManager.kt:50) at ch.sdp.vibester.fragment.GameSetupFragment.setGameSongList(GameSetupFragment.kt:217) at ch.sdp.vibester.fragment.GameSetupFragment.chooseGenre(GameSetupFragment.kt:273) at ch.sdp.vibester.fragment.GameSetupFragment.chooseGenre$default(GameSetupFragment.kt:253) at ch.sdp.vibester.fragment.GameSetupFragment.chooseGame(GameSetupFragment.kt:239) at ch.sdp.vibester.fragment.GameSetupFragment.setGenreListeners$lambda-2(GameSetupFragment.kt:87) at ch.sdp.vibester.fragment.GameSetupFragment.$r8$lambda$KHwOr6KrbnnsD0c8aXctbLKYlwk(Unknown Source:0) at ch.sdp.vibester.fragment.GameSetupFragment$$ExternalSyntheticLambda7.onClick(Unknown Source:2) at android.view.View.performClick(View.java:7792) at android.widget.TextView.performClick(TextView.java:16045) at android.view.View.performClickInternal(View.java:7769) at android.view.View.access$3800(View.java:910) at android.view.View$PerformClick.run(View.java:30184) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:226) at android.os.Looper.loop(Looper.java:313) at android.app.ActivityThread.main(ActivityThread.java:8582) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:563) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1133)

will take a look tomorrow!